Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] Add code owners for V1 #10397

Merged
merged 1 commit into from
Nov 16, 2024
Merged

[V1] Add code owners for V1 #10397

merged 1 commit into from
Nov 16, 2024

Conversation

WoosukKwon
Copy link
Collaborator

Added code owners for vllm/v1

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon WoosukKwon merged commit 661a34f into main Nov 16, 2024
19 of 22 checks passed
@WoosukKwon WoosukKwon deleted the fix-codeowners branch November 16, 2024 18:45
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 18, 2024
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
coolkp pushed a commit to coolkp/vllm that referenced this pull request Nov 20, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Maxime Fournioux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants